Originally with Celtic where he began as a junior, David made fifty League and Cup appearances for them before joining Norwich City on January 17 2007. He made a hundred and five League and Cup appearances for the Canaries, before joining Cardiff City on May 12 2009.
David played in all but two of Cardiff's Championship matches in 2009/10, though struggled with injuries the following campaign. He returned in phenomenal form in 2011/12 however, establishing himself as Malky Mackay's first-choice 'keeper and making forty-seven League appearances. He has represented Scotland at Youth, Under-21, B and Senior levels.